8000 Update `$GITHUB_` and `$RUNNER_` env vars by fniephaus · Pull Request #53 · uraimo/run-on-arch-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update $GITHUB_ and $RUNNER_ env vars #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

Update $GITHUB_ and $RUNNER_ env vars #53

merged 2 commits into from
Jul 29, 2021

Conversation

fniephaus
Copy link
Contributor

This PR updates the list of $GITHUB_ and $RUNNER_ environment variables that are passed into the Docker environment according to the official docs.

Fixes #52 (/cc @marceltaeumel)

fniephaus added 2 commits July 29, 2021 10:24
@fniephaus
Add $GITHUB_ENV and $RUNNER_OS
e12b946
@fniephaus
Sort $GITHUB_ and $RUNNER_ env vars
4c7cf64 
and add missing $GITHUB_ACTION_PATH and $GITHUB_JOB.
@uraimo
Copy link
Owner
uraimo commented Jul 29, 2021

Thanks @fniephaus for the cleanup too.

@uraimo uraimo merged commit 07a46af into uraimo:master Jul 29, 2021
@fniephaus fniephaus deleted the patch-3 branch July 29, 2021 11:56
marceltaeumel added a commit to OpenSmalltalk/opensmalltalk-vm that referenced this pull request Jan 9, 2023
@marceltaeumel
Fixes wrong ASSET_REVISION in LinuxARMv8 builds and other GHA (deprec…
6acf809 
…ation) warnings.

See
- uraimo/run-on-arch-action#53
- http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-January/223049.html
@marceltaeumel
Copy link

Note that $GITHUB_ENV is still not supported in version 2.5.0:

./scripts/ci/actions_build.sh: line 59: /home/runner/work/_temp/_runner_file_commands/set_env_122f1e12-d69c-45fe-89c2-f2ac4833dc08: No such file or directory

See #52

And ::set-output name= will be deprecated soon... :-(
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

8000

@mkurz mkurz mentioned this pull request Jan 12, 2023
Merged
@myfingerhurt
Copy link

In marketplace
https://github.com/marketplace/actions/run-on-architecture
The Basic example is still using echo ::set-output name=uname::$(uname -a)

@uraimo
Copy link
Owner
uraimo commented Feb 15, 2023

@myfingerhurt yes, that other issue is still not fixed in master, I'm doing it in release-3.0.0, not straightforward, they now expect the output to be forwarded to a file on host instead of just grabbing variables from the script output.

Anyway, it should still be just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting $GITHUB_ENV besides "::set-output ..."
4 participants
@fniephaus @uraimo @marceltaeumel @myfingerhurt
0