Add logs api to docker container #135

nacyot · 2014-05-23T05:23:57Z

I add logs api to docker container class.

nahiluhmot · 2014-05-23T11:31:35Z

lib/docker/container.rb

@@ -80,6 +80,12 @@ def to_s
    end
  end

+  [:logs].each do |method|


Why not just def logs?

Agree this would read better as def logs.

nahiluhmot · 2014-05-23T11:32:35Z

One small code comment, but it looks like you have some cane failures. To see them locally, either run bundle exec rake quality or bundle exec cane.

bfulton · 2014-05-23T14:22:25Z

spec/docker/container_spec.rb

@@ -23,6 +23,7 @@
    its(:to_s) { should == expected_string }
  end

+


Extra newline.

bfulton · 2014-05-23T14:28:43Z

@nacyot thanks for adding! Couple minor comments above and cane failures are also minor:

lib/docker/container.rb:88        Line contains trailing whitespace
spec/docker/container_spec.rb:38  Line is >80 characters (87)
spec/docker/container_spec.rb:41  Line contains trailing whitespace
spec/docker/container_spec.rb:57  Line contains trailing whitespace

nacyot · 2014-05-31T13:42:27Z

Sorry for late. I fixed some cane violations and removed extra line. :)

bfulton · 2014-05-31T15:10:34Z

+1

Add logs api to docker container

bfulton · 2014-05-31T15:11:25Z

Thanks @nacyot! Expecting to release later this weekend.

bfulton · 2014-06-02T00:27:47Z

Released in 1.11.0.

Add logs api to docker container

3ef22ae

nahiluhmot reviewed May 23, 2014
View reviewed changes

bfulton reviewed May 23, 2014
View reviewed changes

spec/docker/container_spec.rb

@@ -23,6 +23,7 @@

its(:to_s) { should == expected_string }

end

Copy link

Contributor

bfulton May 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline.

nacyot added 2 commits May 31, 2014 22:38

Fix cane violations

f924d96

Remove extra blank line

c5305e2

bfulton added a commit that referenced this pull request May 31, 2014

Merge pull request #135 from nacyot/master

a6f2bc4

Add logs api to docker container

bfulton merged commit a6f2bc4 into upserve:master May 31, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logs api to docker container #135

Add logs api to docker container #135

		@@ -23,6 +23,7 @@
		its(:to_s) { should == expected_string }
		end

Add logs api to docker container #135

Add logs api to docker container #135

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment