10000 Check for Rake::Task before loading rake tasks by mikz · Pull Request #131 · upserve/docker-api · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Check for Rake::Task before loading rake tasks #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2014
Merged

Check for Rake::Task before loading rake tasks #131

merged 1 commit into from
May 20, 2014

Conversation

mikz
Copy link
Contributor
@mikz mikz commented May 9, 2014

Because if Rake exists and Rake::Task not, loading of docker/rake_task crashes.

@mikz
Check for Rake::Task before loading rake tasks
233e705 
Because if `Rake` exists and `Rake::Task` not loading of `docker/rake_task` crashes.
@bfulton
Copy link
Contributor
bfulton commented May 9, 2014

@mikz thanks for the PR, seems like a good change. When does Rake::Task not exist when Rake does? Also, not sure why the 1.9.3 build failed. Doesn't seem related at first glance.

@mikz
Copy link
Contributor Author
mikz commented May 9, 2014

@bfulton I'm not sure why Rake::Task is not loaded. Might be because one of the gems is requiring just rake and not rake/task. My project does not require it at all.

Anyway, it checks for Rake and then uses Rake::Task so IMO either it should require rake/task or check for Rake::Task.

Also I tried 1.9.3 locally and both master and my patch are green.

@nahiluhmot
Copy link
Contributor

@mikz @bfulton That looks like a transient (haven't seen it before though). I kicked off another build -- if it passes we'll have to look into that.

@mikz
Copy link
Contributor Author
mikz commented May 13, 2014

@nahiluhmot looks like it is still red. Can I do something?

@mikz
Copy link
Contributor Author
mikz commented May 20, 2014

I've found out why it happens.

I'm developing a gem, that has rake as development dependency and in spec_helper I do Bundler.require(:default, :development, :test ) which loads Rake, but not Rake::Test.

So what I can do to get this merged? Build is green now.

@bfulton
Copy link
Contributor
bfulton commented May 20, 2014

@mikz makes sense. Merging.

@nahiluhmot if we see that transient again, let's either figure it out or stop building 1.9.3.

bfulton added a commit that referenced this pull request May 20, 2014
@bfulton
Merge pull request #131 from mikz/patch-1
27c2aa5 
Check for Rake::Task before loading rake tasks
@bfulton bfulton merged commit 27c2aa5 into upserve:master May 20, 2014
@bfulton
Copy link
Contributor
bfulton commented May 20, 2014

@mikz thanks! We should release a new version with this change today.

@mikz mikz deleted the patch-1 branch May 20, 2014 14:57
@bfulton
Copy link
Contributor
bfulton commented May 20, 2014

Fix released in 1.10.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikz @bfulton @nahiluhmot
0