10000 feat: `show_deleted_indicator` by trnxdev · Pull Request #237 · uowuo/abaddon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: show_deleted_indicator #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 25, 2023
Merged

feat: show_deleted_indicator #237

merged 5 commits into from
Oct 25, 2023

Conversation

trnxdev
Copy link
Contributor
@trnxdev trnxdev commented Oct 15, 2023

No description provided.

@trnxdev
Copy link
Contributor Author
trnxdev commented Oct 15, 2023

just found a issue, if I send one message and delete it, the user box is still shown. maybe any advice on how I can fix it?
image

@ouwou
Copy link
Member
ouwou commented Oct 15, 2023

RemoveMessageAndHeader(x); should do what you want

@trnxdev
Copy link
Contributor Author
trnxdev commented Oct 16, 2023 •
edited
Loading

when using RemoveMessageAndHeader or ActuallyRemoveMessage this happens:

After sending 2 Messages (creating a new header), deleting both (successfully, deleting the header correctly too) and trying to send a new message, the app crashes with a Segmentation fault, tried to debug it with gdb a bit

image

UPD: Screenshot made while using RemoveMessageAndHeader method

@ouwou
Copy link
Member
ouwou commented Oct 16, 2023

im not entirely surprised RemoveMessageAndHeader breaks considering i only use it to cull messages from the top down, but a crash in dynamic_cast is weird... ill have a look myself in a bit

@trnxdev
Copy link
Contributor Author
trnxdev commented Oct 17, 2023 •
edited
Loading

but a crash in dynamic_cast is weird...

Maybe it's just lack of my gdb skills, but thanks that you're going to look into that!

Whenever you'll fix it, let me know.

UPD: Also I think I messed up the README a bit

@ouwou
Copy link
Member
ouwou commented Oct 19, 2023

okay, so you just need to do m_id_to_widget.erase(id); after RemoveMessageAndHeader(x);
poor design on my part, hopefully one day i get around to refactoring all the message shit :s

@ouwou
Copy link
Member
ouwou commented Oct 19, 2023

also for README you just forgot a |

@trnxdev trnxdev changed the title feat: show_deleted_messages feat: show_deleted_indicator Oct 19, 2023
@ouwou ouwou merged commit 163749e into uowuo:master Oct 25, 2023
dragontamer8740 pushed a commit to dragontamer8740/abaddon that referenced this pull request Nov 28, 2023
@trnxdev @ouwou @dragontamer8740
feat: show_deleted_indicator (uowuo#237)
a0bfd4e 
* show_deleted_messages

* Update README.md

---------

Co-authored-by: ouwou <26526779+ouwou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trnxdev @ouwou
0