8000 bugfix: fix error on incremental build by alexanderadam · Pull Request #117 · untra/polyglot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bugfix: fix error on incremental build #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

bugfix: fix error on incremental build #117

merged 1 commit into from
Jul 19, 2020

Conversation

alexanderadam
Copy link
Contributor
  • The pull request is complete according to the Definition of Done
    • Acceptance criteria in the ticket have been met
    • Automated tests are written according to the test plan
    • The documentation is up-to-date
    • Deployment automation includes newly introduced environment variables and credentials are added to the credentials.fact file of all servers
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • When applicable, the pull request title starts with the issue number

Would an early return in site.rb in case of nil output do any harm?

PS: I asked this in a comment already.

@untra
Copy link
Owner
untra commented Jul 19, 2020

yeah, this can probably work as intended. sorry, I didn't notice that! good addition 👍

@untra untra merged commit f45a41d into untra:master Jul 19, 2020
@alexanderadam alexanderadam deleted the bugfix/fix-error-on-incremental-build branch July 20, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderadam @untra
0