8000 fix: correctly resolve extended `builtinModules` by pi0 · Pull Request #16 · unjs/exsolve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correctly resolve extended builtinModules #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix: correctly resolve extended builtinModules #16

merged 1 commit into from
Mar 5, 2025

Conversation

pi0
Copy link
Member
@pi0 pi0 commented Mar 5, 2025 •
edited
Loading

Context: nitrojs/nitro#3159

Bun runtime extends node:module's builtinModules export with bun:sqlite (which is NOT a Node.js built-in module).

To avoid wrongly adding prefixes, this patch bypasses check for inputs already containing :

@pi0 pi0 merged commit f6f1058 into main Mar 5, 2025
4 checks passed
@pi0 pi0 deleted the fix/bun-is-not-node branch March 5, 2025 20:02
This was referenced Mar 8, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pi0
0