8000 docs: fix invalid links by iiio2 · Pull Request #46 · unjs/crossws · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix invalid links #46

Merged
merged 4 commits into from
Jul 31, 2024
Merged

docs: fix invalid links #46

merged 4 commits into from
Jul 31, 2024

Conversation

iiio2
Copy link
Contributor
@iiio2 iiio2 commented Jun 26, 2024 •
edited
Loading

if we give "/adapters/bun" like that then it is working in the website, but it will not work on the GitHub md files.

pi0
pi0 reviewed Jul 31, 2024
View reviewed changes
docs/1.guide/5.pubsub.md Outdated Show resolved Hide resolved
docs/1.guide/5.pubsub.md Outdated Show resolved Hide resolved
pi0
pi0 reviewed Jul 31, 2024
View reviewed changes
docs/1.guide/5.pubsub.md Outdated Show resolved Hide resolved
pi0
pi0 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member
@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (using links without domain ensures more portability. for example links should work also on preview deployment URLs).

@pi0 pi0 merged commit e0137df into unjs:main Jul 31, 2024
2 checks passed
@iiio2 iiio2 deleted the patch-1 branch August 25, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iiio2 @pi0
0