8000 feat: add `noAuthors` option by kleinpetr Β· Pull Request #183 Β· unjs/changelogen Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add noAuthors option #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 26, 2025
Merged

feat: add noAuthors option #183

merged 9 commits into from
Feb 26, 2025

Conversation

kleinpetr
Copy link
Contributor

Resolves #174

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

the new option --skipAuthors to avoid Contributors section

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test: add test for skipAuthors option
test: add test commits fixture

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

hrynevychroman

This comment was marked as off-topic.

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
@kleinpetr kleinpetr requested a review from PKief November 13, 2024 12:46
@kleinpetr
Copy link
Contributor Author

@PKief don't understand why but all the tests pass locally but not in the ci

@pi0
Copy link
Member
pi0 commented Nov 13, 2024

@kleinpetr it is a snapshot mismatch, please don't worry about it will check before merge. And again sorry this PR got delayed this much I had been busy on so many other projects.

@PKief
Copy link
Contributor
PKief commented Nov 13, 2024

@PKief don't understand why but all the tests pass locally but not in the ci

Something looks a little weird, because the CI expects this line to be part of the snapshot:

image

Locally, it's working fine for me as well.

Copy link
codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (0914fd7) to head (e01b613).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/default.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #183       +/-   ##
===========================================
- Coverage   69.10%   45.55%   -23.55%     
===========================================
  Files           9       12        +3     
  Lines         916      957       +41     
  Branches       85      102       +17     
===========================================
- Hits          633      436      -197     
- Misses        283      518      +235     
- Partials        0        3        +3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title feat: add skipAuthors (boolean) option feat: add noAuthors option Feb 26, 2025
@pi0 pi0 merged commit 46cd50c into unjs:main Feb 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide contributors
4 participants
0