M1g #1000
Merged
M1g #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the typechecker result more precise and make some illegal state unrepresentable.
current logic picks something arbitrary based on ordering of `Set`, which isn't helping anybody
One remaining loose end is that in recursive definitions are using the suffixified name in the body, for instance: foo.bar.baz x = baz x + 1 the body `baz` should be fully qualified. Fix might be to unhashComponent before printing, or to create a more interesting PPE on a per declaration basis (it could use the non-suffix name for any references part of the same cycle as the declaration itself)
# Conflicts: # parser-typechecker/src/Unison/Codebase/Editor/HandleInput.hs
# Conflicts: # parser-typechecker/src/Unison/Codebase/Editor/HandleInput.hs # parser-typechecker/src/Unison/Codebase/Editor/Output.hs
by using `Result` instead of `M` where possible, because Applicative instance for `Result` accumulates errors.
- minimalCodebaseStructure has been further minimized to just `paths/_head` - `Command.LoadRemoteRootBranch`, `FileCodebase.getRootBranch`, and `Git.pullGitBranch` take a BranchLoadMode argument which dictates whether to fail or silently succeed if the source repo doesn't contain a codebase - documented an unhelpful crash in createDir - no-op instead of crash when `copyFromGit` `from` arg doesn't exist - renamted `writeAllTermsAndTypes` to `syncToDirectory` for readability - we noticed that relative local git repos aren't resolved correctly (they are resolved relative to the git/codebase staging dir where git commands are executed) - pushing to bare repos is untested - added `scripts/test-git.bash` to start collecting git-related tests, but haven't wired it into `.travis.yml`. It could probably also be a regular EasyTest, since it's no longer calling Github APIs.
Parsing and pretty-printing use shortest unique suffix to identify definitions
fix #971 — `push` to empty repo fails
try coaxing travis into folding test output
fixed typo
Update CONTRIBUTORS.markdown
Also curiously transcripts with invalid commands would just silently noop. Now they fail the transcript.
resolve.{term,type} => replace.{term,type}
CI to check for unexpected transcript changes
A few improvements to the typechecking result
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natinstead of.base.Natwhen you only have oneNat!resolve.termandresolve.typecommand toreplace.termandreplace.type(resolve.{term,type} => replace.{term,type} #988)