chore: optimize semantic release workflow to reduce duplicated configuration #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the semantic release workflow by removing duplicated configuration related to the release branch and simplifying branch determination logic.
- Removed the redundant release_branch input and associated branch-setting step.
- Updated the SEMANTIC_RELEASE_RC and RELEASE_BRANCH variables to rely on github.ref_name.
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:57
- [nitpick] Consider adding a comment clarifying the use of github.ref_name to set the release branch, to assist future maintainers in understanding this decision.
RELEASE_BRANCH="${{ github.ref_name }}"
.github/workflows/release.yml:55
- The updated condition now solely checks if github.ref_name equals 'main' which might change the intended behavior from the previous logic that also considered an empty release_branch input. Please verify that relying only on github.ref_name is acceptable for all release scenarios.
SEMANTIC_RELEASE_RC: ${{ inputs.create_rc == true && github.ref_name == 'main' }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.