8000 Prevent extractor panic for invalid PDF text objects by adrg · Pull Request #196 · unidoc/unipdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent extractor panic for invalid PDF text objects #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2019
Merged

Prevent extractor panic for invalid PDF text objects #196

merged 2 commits into from
Oct 30, 2019

Conversation

adrg
Copy link
Collaborator
@adrg adrg commented Oct 28, 2019 •
edited by gunnsth
Loading

Addresses #192

This change is Reviewable

@codecov
Copy link
codecov bot commented Oct 28, 2019 •
edited
Loading

Codecov Report

Merging #196 into development will decrease coverage by 5.48%.
The diff coverage is 71.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #196      +/-   ##
===============================================
- Coverage        57.56%   52.08%   -5.49%     
===============================================
  Files              189      189              
  Lines            34462    34454       -8     
===============================================
- Hits             19839    17944    -1895     
- Misses           12075    14174    +2099     
+ Partials          2548     2336     -212
Impacted Files Coverage Δ
extractor/text.go 40.97% <71.42%> (-24.52%) ⬇️
internal/e2etest/memory_measure.go 0% <0%> (-100%) ⬇️
internal/e2etest/validate.go 0% <0%> (-70%) ⬇️
model/flatten.go 0% <0%> (-64.23%) ⬇️
internal/e2etest/utils.go 0% <0%> (-60%) ⬇️
annotator/field_appearance.go 10.87% <0%> (-39.75%) ⬇️
contentstream/processor.go 17.07% <0%> (-34.46%) ⬇️
model/colorspace.go 10.92% <0%> (-17.07%) ⬇️
model/functions.go 18.76% <0%> (-16.78%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbb567...4a5b791. Read the comment docs.

gunnsth
gunnsth reviewed Oct 28, 2019
View reviewed changes
gunnsth
gunnsth approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor
@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit f7b5ffa into unidoc:development Oct 30, 2019
@adrg adrg deleted the extractor-prevent-panic branch November 26, 2019 18:01
@gunnsth gunnsth added this to the v3.3.1 milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth
0