8000 Creator optimize drawing blocks by adrg · Pull Request #136 · unidoc/unipdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Creator optimize drawing blocks #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2019
Merged

Creator optimize drawing blocks #136

merged 3 commits into from
Jul 31, 2019

Conversation

adrg
Copy link
Collaborator
@adrg adrg commented Jul 31, 2019 •
edited
Loading

Addresses #18

Benchmarks on my computer:

development branch:

BenchmarkParagraphAdding:
2000	711058    ns/op
300     4328161   ns/op
20      90405041  ns/op

creator-draw optimize branch:

BenchmarkParagraphAdding:
2000	621775   ns/op
2000	792756   ns/op
500	2860231  ns/op

This change is Reviewable

@codecov
Copy link
codecov bot commented Jul 31, 2019 •
edited
Loading

Codecov Report

Merging #136 into development will decrease coverage by 0.02%.
The diff coverage is 46.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #136      +/-   ##
===============================================
- Coverage        56.19%   56.16%   -0.03%     
===============================================
  Files              187      187              
  Lines            33614    33624      +10     
===============================================
- Hits             18890    18886       -4     
- Misses           12305    12317      +12     
- Partials          2419     2421       +2
Impacted Files Coverage Δ
creator/creator.go 68.11% <46.66%> (-0.84%) ⬇️
model/optimize/compress_streams.go 50% <0%> (-40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e7eda...c698ec6. Read the comment docs.

gunnsth
gunnsth requested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor
@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Great performance improvement.
I have a couple of feedback questions to look into.

@gunnsth gunnsth merged commit 2a72ef8 into unidoc:development Jul 31, 2019
@gunnsth gunnsth mentioned this pull request Aug 1, 2019
Closed
@adrg adrg deleted the creator-draw-optimize branch August 2, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth
0