8000 Handle improper usage of the array ending marker by adrg · Pull Request #89 · unidoc/unipdf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle improper usage of the array ending marker #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

Handle improper usage of the array ending marker #89

merged 1 commit into from
Jun 14, 2019

Conversation

adrg
Copy link
Collaborator
@adrg adrg commented Jun 12, 2019 •
edited
Loading

Resolves #62 and the file that passes ghostscript validation of issue #63 (376614.pdf)

This change is Reviewable

@codecov
Copy link
codecov bot commented Jun 12, 2019 •
edited
Loading

Codecov Report

Merging #89 into development will decrease coverage by 5.14%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #89      +/-   ##
===============================================
- Coverage        60.16%   55.01%   -5.15%     
===============================================
  Files              154      154              
  Lines            27985    27988       +3     
===============================================
- Hits             16836    15397    -1439     
- Misses           10764    10766       +2     
- Partials           385     1825    +1440
Impacted Files Coverage Δ
core/parser.go 67.99% <0%> (-8.48%) ⬇️
internal/e2etest/utils.go 60% <0%> (-20%) ⬇️
ps/exec.go 62.96% <0%> (-18.52%) ⬇️
core/security/handlers.go 33.33% <0%> (-16.67%) ⬇️
model/optimize/image_ppi.go 59.7% <0%> (-16.42%) ⬇️
model/signature_handler.go 55.04% <0%> (-15.6%) ⬇️
model/reader.go 50.84% <0%> (-14.22%) ⬇️
ps/operations.go 53.45% <0%> (-13.68%) ⬇️
core/stream.go 31.08% <0%> (-13.52%) ⬇️
extractor/image.go 65.51% <0%> (-12.94%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d343...4d43867. Read the comment docs.

gunnsth
gunnsth approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor
@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 7797686 into unidoc:development Jun 14, 2019
@adrg adrg deleted the parser-unexpected-pattern branch June 17, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrg @gunnsth
0