make i386 instructions RDTSC and RDTSCP hookable #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>
Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>
|
I'm good with this PR. Would you mind writing a small unit test to |
Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>
|
@wtdcode PTAL |
Looks good and thanks. Will merge once CI passes. (Windows is broken at this moment) |
|
We need to rerun the failed CI job. It has failed with |
|
Thanks! |
hyunmin-furiosa
pushed a commit
to hyunmin-furiosa/unicorn
that referenced
this pull request
Jan 17, 2025
* instruction hooks for RDTSC and RDTSCP Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com> * update hookable instruction list Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com> * test RDTSC and RDTSCP instruction hooks Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com> --------- Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com> Co-authored-by: mio <mio@lazym.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the RDTSC and RDTSCP instructions to be hooked. The code is based on the CPUID hook implementation.
Fixes #2065