Modernize CMake #1373
Merged
Modernize CMake #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c4f42f to
42d0682
Compare
|
Nice contribution. Just a question: Does it also work with |
|
Everything is backwards compatible. In general you probably shouldn’t use find_library though, use find_package instead (although I don’t know if that works). |
|
Oh sry, I mean find_package. Does that work?
…________________________________
From: Duncan Ogilvie ***@***.***>
Sent: Tuesday, March 30, 2021 4:54:28 PM
To: unicorn-engine/unicorn ***@***.***>
Cc: lazymio ***@***.***>; Comment ***@***.***>
Subject: Re: [unicorn-engine/unicorn] Modernize CMake (#1373)
Everything is backwards compatible. In general you probably shouldn’t use find_library though, use find_package instead (although I don’t know if that works).
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1373 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULO3TJDKIMTAGZEJCXKDTGGGUJANCNFSM4XNPKSRA>.
|
|
No idea. I just made everything backwards compatible. If the install is
done correctly it’ll probably work.
…On Tue, 30 Mar 2021 at 11:01, lazymio ***@***.***> wrote:
Oh sry, I mean find_package. Does that work?
________________________________
From: Duncan Ogilvie ***@***.***>
Sent: Tuesday, March 30, 2021 4:54:28 PM
To: unicorn-engine/unicorn ***@***.***>
Cc: lazymio ***@***.***>; Comment ***@***.***>
Subject: Re: [unicorn-engine/unicorn] Modernize CMake (#1373)
Everything is backwards compatible. In general you probably shouldn’t use
find_library though, use find_package instead (although I don’t know if
that works).
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
#1373 (comment)>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AHJULO3TJDKIMTAGZEJCXKDTGGGUJANCNFSM4XNPKSRA>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1373 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASYFGPF5RHIHBAMTQDLBNTTGGHOZANCNFSM4XNPKSRA>
.
|
|
merged, thanks! |
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone
Merged
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
mrexodia
added a commit
to mrexodia/unicorn
that referenced
this pull request
Jan 18, 2022
Everything from unicorn-engine#1373 seems to have been undone, so I did it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did my best to modernize the CMake a bit and add options for installation/samples, which will allow users to add unicorn to their CMake projects by doing
add_subdirectory(or FetchContent). Everything is backwards compatible and when installing unicorn I get the same outputs.Example project that automatically downloads and compiles unicorn: https://github.com/mrexodia/unicorn_template