8000 fix: pnpm 8 install minimal version in create-dumi by PeachScript · Pull Request #1628 · umijs/dumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pnpm 8 install minimal version in create-dumi #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix: pnpm 8 install minimal version in create-dumi #1628

merged 2 commits into from
Apr 25, 2023

Conversation

PeachScript
Copy link
Member
@PeachScript PeachScript commented Apr 25, 2023 •
edited
Loading

🤔 这个变动的性质是？/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

Close #1620

💡 需求背景和解决方案 / Background or solution

PNPM v8 默认安装依赖声明的最小版本号，如果 create-dumi 模板中的 dumi 版本太旧，如果安装最新的主题包（比如 mobile 或三方主题包）可能会工作异常，做了两个优化：

  1. 如果用户安装的是 PNPM v8，则执行 pnpm up -L 而非 pnpm i
  2. create-dumi 构建的时候每次取仓库里当前的 dumi 版本作为模板版本

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English Fix pnpm 8 install minimal version in create-dumi
🇨🇳 Chinese 修复 create-dumi 使用 pnpm 8 时始终安装最小版本的问题

@vercel
Copy link
vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview Apr 25, 2023 2:13am

@PeachScript PeachScript merged commit c8ef1fc into master Apr 25, 2023
@PeachScript PeachScript deleted the hotfix/create-dumi-pnpm-8 branch April 25, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dumi-theme-mobile@2.0.4 安装后启动后报错
1 participant
@PeachScript
0