8000 Disable Vue due to 80-char wrap bug by glenn-jocher · Pull Request #451 · ultralytics/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable Vue due to 80-char wrap bug #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 11, 2025
Merged

Disable Vue due to 80-char wrap bug #451

merged 5 commits into from
May 11, 2025

Conversation

glenn-jocher
Copy link
Member
@glenn-jocher glenn-jocher commented May 11, 2025 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved file header handling for Vue components and updated the package version. 🚀

📊 Key Changes

  • Changed the comment style for .vue files to use HTML comments (<!-- ... -->) instead of JavaScript-style comments.
  • Bumped the package version from 0.0.78 to 0.0.79.

🎯 Purpose & Impact

  • Ensures that file headers in Vue components are properly formatted, preventing issues with code formatting tools like Prettier.
  • Keeps the package versioning up to date, signaling a minor but important improvement for users and developers working with Vue files.

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working dependencies Dependencies and packages enhancement New feature or request labels May 11, 2025
@UltralyticsAssistant
Copy link
Member

👋 Hello @glenn-jocher, thank you for submitting an ultralytics/actions 🚀 PR! This is an automated response to help streamline the review process. An Ultralytics engineer will also assist you soon.

Please review the following checklist to ensure your pull request is ready for integration:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Make sure your commit messages remain clear and follow the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is up to date with the ultralytics/actions main branch. If your branch is behind, update it by clicking 'Update branch' or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Make sure all Ultralytics Continuous Integration (CI) checks are passing. Address any issues if checks fail.
  • ✅ Update Documentation: Update the relevant documentation for any new or changed features as needed.
  • ✅ Add Tests: If applicable, add or update tests to cover your changes and confirm all tests are passing.
  • ✅ Sign the CLA: If this is your first Ultralytics PR, please sign our Contributor License Agreement by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • ✅ Minimize Changes: Limit your changes to only what is necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

You can find more details in the Contributing Guide. If you have any questions, feel free to leave a comment. Thank you for helping improve Ultralytics! 🚀✨

@codecov Codecov
Copy link
codecov bot commented May 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (b10f331) to head (7ef1e35).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   67.30%   67.30%           
=======================================
  Files          22       22           
  Lines        1312     1312           
=======================================
  Hits          883      883           
  Misses        429      429

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glenn-jocher and others added 4 commits May 11, 2025 18:32
@glenn-jocher
Update update_file_headers.py
2289c24 
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher
Update update_file_headers.py
3a2d603 
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant
Auto-format by https://ultralytics.com/actions
1364add
@glenn-jocher
Disable Vue due to 80-char wrap bug
7ef1e35
@glenn-jocher glenn-jocher merged commit 559f962 into main May 11, 2025
11 checks passed
@glenn-jocher glenn-jocher deleted the vue2 branch May 11, 2025 16:35
@UltralyticsAssistant
Copy link
Member

Fantastic work, @glenn-jocher! 🚀 Your attention to detail in improving file header handling for Vue components and keeping the package version up to date is truly appreciated. As Leonardo da Vinci once said, "Details make perfection, and perfection is not a detail." Your commitment to these refinements ensures a smoother experience for both developers and users. Thank you for making Ultralytics projects even better—your contributions drive excellence forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working dependencies Dependencies and packages enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glenn-jocher @UltralyticsAssistant
0