8000 Remove "Add Views EntityReference filter to be available for all entity reference fields" patch by joewhitsitt · Pull Request #8752 · uiowa/uiowa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove "Add Views EntityReference filter to be available for all entity reference fields" patch #8752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

Remove "Add Views EntityReference filter to be available for all entity reference fields" patch #8752

merged 2 commits into from
May 8, 2025

Conversation

joewhitsitt
Copy link
Contributor
@joewhitsitt joewhitsitt commented May 8, 2025 •
edited
Loading

Resolves #6039

How to test

ddev composer install && ddev blt frontend && ddev drush @admissions.local sql-drop -y && ddev drush @admissions.local cr && ddev blt ds --site=admissions.uiowa.edu && ddev drush @admissions.local uli areas-of-study

Test to make sure the filtering still work as https://admissions.uiowa.edu/areas-of-study does

@joewhitsitt joewhitsitt added gone rogue DX Code clean-up, lowering technical debt, pruning labels May 8, 2025
@joewhitsitt joewhitsitt marked this pull request as ready for review May 8, 2025 16:21
@joewhitsitt joewhitsitt requested a review from a team May 8, 2025 16:21
pyrello
pyrello approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor
@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking care of this!

@pyrello pyrello merged commit 74faa51 into main May 8, 2025
2 checks passed
@pyrello pyrello deleted the dx_remove_patch branch May 8, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrello pyrello pyrello approved these changes

Assignees
No one assigned
Labels
DX Code clean-up, lowering technical debt, pruning gone rogue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate whether Views EntityReference patch is necessary
2 participants
@joewhitsitt @pyrello
0