8000 Events single page multiple-dates dropdown color contrast fix by bspeare · Pull Request #8660 · uiowa/uiowa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Events single page multiple-dates dropdown color contrast fix #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Events single page multiple-dates dropdown color contrast fix #8660

merged 3 commits into from
Apr 9, 2025

Conversation

bspeare
Copy link
Contributor
@bspeare bspeare commented Apr 8, 2025

Resolves #5495.

How to test

ddev blt ds --site=sandbox.uiowa.edu && ddev drush @sandbox.local uli /event/31316/21
  1. Confirm that first date has more space between it and the remaining dates
  2. Confirm new gray color passes AA validation: https://webaim.org/resources/contrastchecker/?fcolor=737373&bcolor=FFFFFF.

@pyrello pyrello self-assigned this Apr 9, 2025
@pyrello
Copy link
Contributor
pyrello commented Apr 9, 2025

Pulling to test.

pyrello
pyrello approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor
@pyrello pyrello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@bspeare bspeare merged commit 9dc74e0 into main Apr 9, 2025
2 checks passed
@bspeare bspeare deleted the events_multiple_dates_a11y_fix branch April 9, 2025 16:22
@pyrello pyrello removed their assignment Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrello pyrello pyrello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events single page multiple-dates dropdown need more color contrast
2 participants
@bspeare @pyrello
0