8000 disable testing sparsity pattern in PETSc builds by norihiro-w · Pull Request #1550 · ufz/ogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

disable testing sparsity pattern in PETSc builds #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2016
Merged

disable testing sparsity pattern in PETSc builds #1550

merged 1 commit into from
Nov 17, 2016

Conversation

norihiro-w
Copy link
Collaborator
@norihiro-w norihiro-w commented Nov 17, 2016 •
edited
Loading

as titled. this fixes the Jenkins error

@chleh
Copy link
Collaborator
chleh commented Nov 17, 2016

Has Jenkins been failing for a longer time because of these tests? There haven't been any changes to the sparsity pattern code recently (#1549 not merged yet), right? Do you know why the tests fail so badly that they have to be disabled?

@norihiro-w
Copy link
Collaborator Author

it's because of #1548

@chleh
Copy link
Collaborator
chleh commented Nov 17, 2016

Is it then possible to properly fix the tests in a reasonable amount of time instead of just disabling them?
Or, does it make sense to fix them, i.e. does it make sense to run the same sparsity pattern test for PETSc and non-PETSc builds?

@norihiro-w
Copy link
Collaborator Author

unfortunately not, because

  • this PR fixes the sparsity pattern for the Eigen case. The sparsity pattern PETSc requires is different.
  • PETSc builds requires passing NodePartitionedMesh to MeshComponentMap. The tests need to somehow support creating the partitioned mesh.

@chleh
Copy link
Collaborator
chleh commented Nov 17, 2016

I just saw, you introduced the tests in #1548. And they fail this way:

testrunner: /gpfs1/data/ogs/jenkins/workspace/OGS-6/Linux-PRs-dynamic/ogs/NumLib/DOF/MeshComponentMap.cpp:68: NumLib::MeshComponentMap::MeshComponentMap(const std::__debug::vector<std::unique_ptr<MeshLib::MeshSubsets> >&, NumLib::ComponentOrder): Assertion `dynamic_cast<MeshLib::NodePartitionedMesh const*>( &mesh_subset.getMesh()) != nullptr' failed.

So disabling them is OK for me. ⏩

@norihiro-w norihiro-w merged commit 6e64301 into ufz:master Nov 17, 2016
@norihiro-w norihiro-w deleted the fix-test-sparsity branch November 17, 2016 09:06
@norihiro-w
Copy link
Collaborator Author

yes sorry I should have written that at the beginning. this PR is fix up of #1548.

@ogsbot
Copy link
Member
ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norihiro-w @chleh @ogsbot
0