General Parameter interface. #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this please. |
|
|
||
| // TODO other data types than only double | ||
| auto const& property = | ||
| mesh.getProperties().template getPropertyVector<double>(field_name); |
There was a problem hiding this comment.
Removed. GCC eats it without it.
|
Code looks okay to me. After resolving conflicts: ⏩ |
| std::vector<T> const& getTuple(double const /*t*/, | ||
| SpatialPosition const& pos) const override | ||
| { | ||
| auto const e = pos.getNodeID(); |
|
⏩ afterwards... |
e4835a6 to
b46d339
Compare
|
I won't squash the remaining fixup commits since I have a file rename commit in between and I'm too lazy to untangle this. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predecessor of #1356.
This PR introduces a general Parameter class whose main features are:
double tandclass SpatialPositionand SpatialPosition
The
SpatialPositionclass represents either a node, an element, an integration point or a set of coordinates.