fix internally setting BOOST_ROOT from env var #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@norihiro-w Could you give a short description of the problem, or maybe how to reproduce it, or any hint what was going wrong before? |
|
Previously in CMake, BOOST_ROOT var was set to "$ENV{BOOST_ROOT}; TRUE". |
|
I think TRUE is simply unnecessary there as far as I read the documentation of SET() |
|
Yes the |
|
Just a suggestion, although it is disputed, I would have rebased before the merge to check if there are any incompatibilities (on compilation level/test level). |
|
generally yes but I don't think that is necessary for this tiny fix. |
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a problem that a environmental variable BOOST_ROOT doesn't work