[FileIO] GmshInterface #1212
[FileIO] GmshInterface #1212
Conversation
|
Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1770/ |
|
MathLib.DenseGaussAlgorithm test fails. I did not change anything concerning the Gauss algorithm. I think it is the same issue #997 @rinkk reported some months ago. |
| @@ -0,0 +1,57 @@ | |||
| /** | |||
| * \brief Declaration of class PolygonWithSegmentMarker. | |||
There was a problem hiding this comment.
Definition, not declaration...
|
👍 |
| GMSHInterface gmsh_io( | ||
| _project.getGEOObjects(), true, | ||
| FileIO::GMSH::MeshDensityAlgorithm::AdaptiveMeshDensity, | ||
| 0.05, 0.5, 2, selected_geometries); |
There was a problem hiding this comment.
Do the hardcoded parameters have any significance for saving geo-files?
There was a problem hiding this comment.
Yes, the parameters are used within GMSHInterface::writeGMSHInputFile() which is deployed for saving geo-files.
There was a problem hiding this comment.
So we just assume these values are correct when writing a geo-file? I just want to understand why specific parameter values are given when that wasn't necessary before. Because the resulting geo-file will be quite specific concerning the mesh that will would be created based on it.
There was a problem hiding this comment.
The previous code used exact the same values internally. There are no new assumptions introduced.
There was a problem hiding this comment.
Okay. It wasn't obvious before. It's okay for debugging geo-files but here should probably be an option to adjust these values. Maybe later....
Before inserting the new polyline, there should be some tests performed with the already existing polylines.
The points are inserted already in initMeshDensityStrategy().
fixup new DataHolderLib::Project
Functionality is avaiable from other methods of the class.
The check prevents to insert a line that is already a part of the node polygon.
Avoid implicit generation of - copy constructor, - move constructor, - assignment operator and - move assignment operator.
Control switches rotate and keep_preprocessed_geometry.
clang-tidy '-checks=modernize-use-auto,readability-simplify-boolean-expr' -p=../b/ FileIO/GMSHInterface.cpp
|
OpenGeoSys development has been moved to GitLab. |
The PR
PolygonWithSegmentMarkerandPolylineWithSegmentMarkerinGeoLibin order to mark already preprocessed line segments in the GMSHPolygonTree.