8000 Remove mesh lib on file io dependency by endJunction · Pull Request #1153 · ufz/ogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove mesh lib on file io dependency #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2016
Merged

Remove mesh lib on file io dependency #1153

merged 2 commits into from
Apr 21, 2016
8000

Conversation

endJunction
Copy link
Member
@endJunction endJunction commented Apr 19, 2016 •
edited
Loading

Somehow this dependency slipped past my mind.
Moving reading of the file into DE.

Use instead layered mesh constructor taking a GeoLib::Raster.
Reading of the raster happens inside the application now.

Typo was "wher". No changes to the comment otherwise.

TomFischer
TomFischer reviewed Apr 21, 2016
View reviewed changes
Applications/DataExplorer/DataView/MshView.cpp
{
OGSError::box(QString::fromStdString(
"Error mapping mesh. Could not read raster file " +
dlg.getRasterPath()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice side effect: A possible error message can be displayed directly in the DataExplorer.

@TomFischer
Copy link
Member

⏩

@chleh
Copy link
Collaborator
chleh commented Apr 21, 2016

⏩
@endJunction, once you have finished disentangling the various OGS6 libs, could you please provide a drawing (maybe hand-drawn) depicting the dependency graph among the libs, because sometimes there could be two options: E.g., either MeshLib depends on FileIO or the other way around.

@endJunction
Copy link
Member Author
endJunction commented Apr 21, 2016 •
edited
Loading

For uptodate relations see Doxygen, e.g. for MeshLib where there is MeshLib<->FileIO dependency, but will be "FileIO depends on MeshLib only" after this is merged.
(Though the docs are rebuild nightly, not after every merge.)

@endJunction
[MeL] Remove layered mesh creation from filepaths.
84349c2 
Use instead layered mesh constructor taking a GeoLib::Raster.
Reading of the raster happens inside the application now.
@endJunction
[MeL] Typo in comment.
d1697e1
@endJunction endJunction merged commit 2c15d6e into ufz:master Apr 21, 2016
@endJunction endJunction deleted the RemoveMeshLibOnFileIODependency branch April 21, 2016 12:31
@ogsbot
Copy link
Member
ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endJunction @TomFischer @chleh @ogsbot
0