8000 Header-only Boost by bilke · Pull Request #940 · ufz/ogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Header-only Boost #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2016
Merged

Header-only Boost #940

merged 2 commits into from
Jan 6, 2016

Conversation

bilke
Copy link
Member
@bilke bilke commented Jan 5, 2016

Related to #939

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/978/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/882/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/956/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/861/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/882/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/979/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/862/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/883/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/883/

@ogsbot
Copy link
Member
ogsbot commented Jan 5, 2016

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/957/

TomFischer
TomFischer reviewed Jan 6, 2016
View reviewed changes
Tests/FileIO/TestXmlGmlReader.cpp
@@ -209,7 +209,7 @@ TEST_F(FileIOXmlGml, QtXmlGmlWriterReaderTest)
{
// Writer test
std::string test_data_file(BaseLib::BuildInfo::tests_tmp_path
+ boost::filesystem::unique_path().string() + ".gml");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the reason to change the code here, but I like the unique_path feature also. I opened an issue #942 for further discussion separate from this PR.

@TomFischer
Copy link
Member

⏩

TomFischer
TomFischer reviewed Jan 6, 2016
View reviewed changes
scripts/cmake/ExternalProjectBoost.cmake
elseif(OGS_LIB_BOOST STREQUAL "Default")
find_package(Boost 1.46.0 COMPONENTS ${BOOST_LIBS_TO_BUILD})
find_package(Boost 1.46.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this in another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could update the required version in #912 once this PR is merged, since my PR really changes the requirement.

endJunction added a commit that referenced this pull request Jan 6, 2016
@endJunction
Merge pull request #940 from bilke/boost-cleanup
cba5baf 
Header-only Boost
@endJunction endJunction merged commit cba5baf into ufz:master Jan 6, 2016
@bilke bilke deleted the boost-cleanup branch January 6, 2016 13:24
@ogsbot
Copy link
Member
ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bilke @ogsbot @TomFischer @chleh @endJunction
0