[pull] master from kubernetes-csi:master #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4182615451
💛 - Coveralls |
test: fix stdlib CVE due to golang v1.22.2
The user might put non-unique spec for subdir:
```
subDir: ${pvc.metadata.namespace}/${pvc.metadata.name}
```
Then, `os.Rename(internalVolumePath, archivedInternalVolumePath)` can fail becaue the destination (`archivedInternalVolumePath`) already exists. It's safer to remove it before `os.Rename()`.
…opy-before-Rename fix: Remove stale archived volume copy before Rename
test: fix storageclass uncleaned
Bumps build-image/debian-base from bookworm-v1.0.2 to bookworm-v1.0.3. --- updated-dependencies: - dependency-name: build-image/debian-base dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…plugin/build-image/debian-base-bookworm-v1.0.3 chore(deps): bump build-image/debian-base from bookworm-v1.0.2 to bookworm-v1.0.3 in /cmd/smbplugin
doc: cut v1.15.0 release
fix: windows image 1809 build failure
Modern GNU make (version >= 4.4) has backward-incompatibile feature: > * WARNING: Backward-incompatibility! > Previously makefile variables marked as export were not exported to commands > started by the $(shell ...) function. Now, all exported variables are > exported to $(shell ...). If this leads to recursion during expansion, then > for backward-compatibility the value from the original environment is used. This makes any invocation of `make` command very costly. Compare the performance of make 4.3 vs. 4.4: ``` $ time ~/Sources/make-4.3/make smb ARCH=$(go env GOARCH) CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -ldflags "-X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.driverVersion=v1.15.0 -X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.gitCommit=f5ced814f628ddee2c9f3e6af505c5a6123e50f4 -X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.buildDate=2024-05-15T00:00:09Z -s -w -extldflags "-static"" -mod vendor -o _output/amd64/smbplugin ./cmd/smbplugin real 0m38.504s user 3m50.580s sys 0m23.502s $ time ~/Sources/make-4.4/make smb ARCH=$(go env GOARCH) CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -ldflags "-X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.driverVersion=v1.15.0 -X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.gitCommit=f5ced814f628ddee2c9f3e6af505c5a6123e50f4 -X github.com/kubernetes-csi/csi-driver-smb/pkg/smb.buildDate=2024-05-15T00:04:04Z -s -w -extldflags "-static"" -mod vendor -o _output/amd64/smbplugin ./cmd/smbplugin real 16m59.851s user 13m16.490s sys 13m46.418s ``` The same variables are evaluated again and again millions times: ``` $ rpm -qf /usr/bin/make make-4.4.1-6.fc40.x86_64 $ /usr/bin/make -d smb ARCH=$(go env GOARCH) 2>&1 |grep "not recursively expanding.*to export to shell function" |wc -l 2171342 ``` The patch doesn't change user-visible behavior of Makefile, but makes `make` command as performant as it used to be in case of make 4.3.
cleanup: remove v1.15.0 release since windows image build is broken
…iable-expansions fix: Remove excessive recursive variable expansions
Remove 0.15.0 from index.yaml too.
Update index.yaml - remove 1.15.0 from index.yaml
f40f0ccd4 Merge pull request #256 from solumath/master cfa92106c Instruction update 379a1bb9b Merge pull request #255 from humblec/sidecar-md a5667bbbb fix typo in sidecar release process 49676850e Merge pull request #254 from bells17/add-github-actions d9bd160c2 Update skip list in codespell GitHub Action adb3af9df Merge pull request #252 from bells17/update-go-version f5aebfc9f Add GitHub Actions workflows b82ee3888 Merge pull request #253 from bells17/fix-typo c31745621 Fix typo 0a7850561 Bump to Go 1.22.3 edd89ad58 Merge pull request #251 from jsafrane/add-logcheck 043fd0991 Add test-logcheck target d7535ae0c Merge pull request #250 from jsafrane/go-1.22 b52e7ad35 Update go to 1.22.2 14fdb6f66 Merge pull request #247 from msau42/prow dc4d0ae20 Merge pull request #249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version 9b4352e9f Update release playbook c7bb972cc Fix release notes script to use fixed tags 463a0e9f5 Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: f40f0ccd458f2d4555e3ca98d69b5a984bae0f14
chore: update release-tools to fix spelling error
chore: use go 1.22 in go.mod
fix: shield guard issues
test: correct external-e2e driver capabilities
fix golint
chore: use go1.24
test: fix CVE-2025-22871 in trivy action
chore: upgrade resizer sidecar image version to v1.13.2
fix: goroutine leak when timeout
doc: cut v1.18.0 release
test: fix CVE-2025-4673 in trivy action
Bumps build-image/debian-base from bookworm-v1.0.4 to bookworm-v1.0.5. --- updated-dependencies: - dependency-name: build-image/debian-base dependency-version: bookworm-v1.0.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…plugin/build-image/debian-base-bookworm-v1.0.5 chore(deps): bump build-image/debian-base from bookworm-v1.0.4 to bookworm-v1.0.5 in /cmd/smbplugin
chore: upgrade sidecar image versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )