SNR Taper Adjustment #182
Open
SNR Taper Adjustment #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewRidden-Harper
approved these changes
May 18, 2025
lispandfound
requested changes
May 20, 2025
| @@ -80,27 +77,32 @@ def calculate_snr( | |||
| ValueError | |||
| If the noise duration is less than 1s and so SNR can't be computed. | |||
| """ | |||
| # This extra time is to ensure that when a taper is applied, the signal part of the waveform | |||
| # is not affected by the tapering. The tapering is applied to the signal and noise separately. | |||
| tp_extra = 20 * waveform[:, tp:].shape[1] / 19 - waveform[:, tp:].shape[1] | |||
There was a problem hiding this comment.
This is a bit clearer IMO if you factor and then convert to decmals
tp_extra = 20 * nt / 19 - nt
= (20 / 19 - 1) * nt
= nt / 19
or
~ 0.0526 * nt
Did you maybe mean 0.05 * nt?
Suggested change
| tp_extra = 20 * waveform[:, tp:].shape[1] / 19 - waveform[:, tp:].shape[1] | |
| tp_extra = waveform[:, tp:].shape[1] / 19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler approach to solving an issue with double tapers on SNR and the impacts of tapering at tp.
Now we adjust the signal window to include some of the noise, but only parts that actually will be dampened out by the taper of 5%.
Was going to add tests to ensure that we don't taper the value at tp, but would require returning the snr_signal values which is too much extra work, so instead added an assert which will do the same.