Use non-lock-file conda requirements in RTD #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
approved these changes
Jan 18, 2024
|
Edit: Upon further inspection this seems like a RTD configuration issue where it isn't parsing the lock-file properly (instead of a pinned RTD theme issue). |
1ed20dc to
bc6af92
Compare
sphinx_rtd_theme in Conda|
Are the CI failures related to this change? |
|
No they aren't and it's unclear why things would break. Couldn't get around to this today. I'll look over the weekend |
|
This was the issue. Downgrading OpenJDK <= 20 works. sbt/sbt#7235 |
jerryz123
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTD changed to not allow lock-files in the
.readthedocs.yamlconfiguration. So now, lets instead use the environment file directly.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?