8000 Final Release Prep by abejgonzalez · Pull Request #1448 · ucb-bar/chipyard · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Final Release Prep #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 7, 2023
Merged

Final Release Prep #1448

merged 9 commits into from
May 7, 2023

Conversation

abejgonzalez
Copy link
Contributor
@abejgonzalez abejgonzalez commented Apr 20, 2023 •
edited
Loading

See title.

TODO:

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Apr 20, 2023
@abejgonzalez abejgonzalez changed the title Update FireSim Final Release Prep Apr 20, 2023
jerryz123
jerryz123 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor
@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think its fine to merge this in now, and handle the TODOs in follow-up PRs. Up to you.

@abejgonzalez
Copy link
Contributor Author

Still waiting on FireSim PR: firesim/firesim#1492 and the TODOs (including the Hammer PR). Then we can use this branch to circular bump everything. So let's hold off a bit.

jerryz123
jerryz123 requested changes Apr 21, 2023
View reviewed changes
@jerryz123
Copy link
Contributor

@abejgonzalez I took the liberty of cleaning up this PR now that the uniquify fix is in (thanks @joey0320).

No other chipyard PRs need to go in at this point, 1.9.1 is ready, pending firesim

@jerryz123
Copy link
Contributor

The run-cfg-finder job seems to have failed spuriously.
I'm going to push the release

@jerryz123 jerryz123 merged commit 968b207 into main May 7, 2023
@jerryz123 jerryz123 deleted the bump-fs branch May 7, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@sagark sagark Awaiting requested review from sagark

Assignees

@abejgonzalez abejgonzalez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abejgonzalez @jerryz123
0