8000 Default VCS simulators should generate FSDB by jerryz123 · Pull Request #1252 · ucb-bar/chipyard · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default VCS simulators should generate FSDB #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2022
Merged

Default VCS simulators should generate FSDB #1252

merged 1 commit into from
Oct 16, 2022

Conversation

jerryz123
Copy link
Contributor

VPD is going away, we should default to generating FSDB.
If the user wants VPD, they set the USE_VPD flag. (USE_FSDB is ignored now, everything should default to FSDB).

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

abejgonzalez
abejgonzalez approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor
@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SFTM

@jerryz123 jerryz123 merged commit fb2f83b into main Oct 16, 2022
@jerryz123 jerryz123 deleted the fsdb branch January 6, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
changelog:changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @abejgonzalez
0