8000 feat(ga4gh): move DRS access API to fence by Avantol13 · Pull Request #957 · uc-cdis/fence · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

feat(ga4gh): move DRS access API to fence #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 8, 2021
Merged

feat(ga4gh): move DRS access API to fence #957

merged 10 commits into from
Sep 8, 2021

Conversation

Avantol13
Copy link
Contributor

Move the /access portion of the DRS API to fence (from indexd). This more closely consolidates the functionality of creating signed URLs into a single service (fence). This should improve performance (as the existing setup requires roundtrip requests from indexd -> fence -> indexd (creating some strange circular dependencies).

New Features

  • Expose /ga4gh/drs/v1/objects/{object_id}/access/{access_id} GA4GH DRS Access API via Fence

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link
github-actions bot commented Sep 1, 2021

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link
coveralls commented Sep 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 11677

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 72.151%
Files with Coverage Reduction New Missed Lines %
fence/resources/user/user_session.py 1 86.79%
Totals Coverage Status
Change from base Build 11672: 0.03%
Covered Lines: 6459
Relevant Lines: 8952
💛 - Coveralls

@BinamB
Copy link
Contributor
BinamB commented Sep 8, 2021

I guess it doesnt matter if we remove this access endpoint from indexd now or later since it would route to fence but we should definitely remove it at some point so as to not bloat indexd.

Also should probably add these to the swagger doc

@Avantol13
Copy link
Contributor Author

I guess it doesnt matter if we remove this access endpoint from indexd now or later since it would route to fence but we should definitely remove it at some point so as to not bloat indexd.

Also should probably add these to the swagger doc

Yeah, I didn't want to remove it from indexd the same time I added to fence; I want to leave a transition period. It won't necessarily hurt to have the indexd one (people will just get better performance from the fence one). But agreed we should remove it eventually

BinamB
BinamB approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor
@BinamB BinamB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Avantol13 Avantol13 merged commit dbedbf6 into master Sep 8, 2021
@Avantol13 Avantol13 deleted the feat/ga4gh_drs branch September 8, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinamB BinamB BinamB approved these changes

Assignees
No one assigned
Labels
test-apis-auditServiceTest test-google-googleServiceAccountTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Avantol13 @coveralls @BinamB @Avantol13-machine-user
0