8000 Delete the code related to react native by 8845musign · Pull Request #46 · ubie-oss/ubie-icons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Delete the code related to react native #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We 8000 ’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2024
Merged

Delete the code related to react native #46

merged 2 commits into from
Aug 2, 2024

Conversation

8845musign
Copy link
Contributor
@8845musign 8845musign commented Aug 1, 2024 •
edited
Loading

Changes

  • Delete the code related to react native
    • If there is a native dependency, react dependency resolution will fail.
    • Icons for native are prepared in a separate repository.

@8845musign 8845musign force-pushed the delete-native-build branch from 3926202 to 001d06e Compare August 1, 2024 02:50
@8845musign
Delete the code related to react native
7e906c8 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
Deletion omission
087dd7e 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign 8845musign force-pushed the delete-native-build branch from d1477d5 to 087dd7e Compare August 1, 2024 03:03
@8845musign 8845musign marked this pull request as ready for review August 1, 2024 03:05
@takanorip takanorip self-requested a review August 2, 2024 10:28
takanorip
takanorip approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor
@takanorip takanorip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@takanorip takanorip merged commit cc0d28b into ubie-oss:main Aug 2, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip
0