8000 Change package configuration to match Chat by uakihir0 · Pull Request #63 · uakihir0/kbsky · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change package configuration to match Chat #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 1, 2024
Merged

Change package configuration to match Chat #63

merged 6 commits into from
Jul 1, 2024

Conversation

uakihir0
Copy link
Owner
@uakihir0 uakihir0 commented Jun 27, 2024 •
edited
Loading

The following changes were made in this PR

  • Changed bsky package to app.bsky
  • chat package changed to chat.bsky
  • Changed the naming of some classes to match other classes.
  • Added some Chat related tests

この PR では以下の変更をしました。

  • bsky パッケージを app.bsky に変更
  • chat パッケージを chat.bsky に変更
  • 他のクラスに合わせて一部クラスの命名の変更
  • Chat 関連のテストを一部追加

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 27, 2024 •
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

241 files out of 300 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@uakihir0 uakihir0 mentioned this pull request Jun 27, 2024
Merged
@uakihir0 uakihir0 changed the title preparing for impl dm. Chat に合わせたパッケージ構成の変更 Jun 27, 2024
@uakihir0 uakihir0 changed the title Chat に合わせたパッケージ構成の変更 Change package configuration to match Chat Jun 27, 2024
uakihir0 added 3 commits June 28, 2024 00:42
@uakihir0
fix test package name.
bde770f
@uakihir0
Merge branch 'main' into f/dm
2210122 
# Conflicts:
#	core/src/commonMain/kotlin/work/socialhub/kbsky/model/app/bsky/actor/ActorDefsProfileAssociated.kt
#	core/src/comm
8000
onMain/kotlin/work/socialhub/kbsky/model/app/bsky/actor/ActorDefsProfileAssociatedChat.kt
#	core/src/commonMain/kotlin/work/socialhub/kbsky/model/app/bsky/actor/ActorDefsProfileViewBasic.kt
#	core/src/commonMain/kotlin/work/socialhub/kbsky/util/json/AnySerializer.kt
@uakihir0
add chat implimentation.
ea2ab91
@uakihir0 uakihir0 marked this pull request as ready for review June 28, 2024 16:13
@uakihir0
Copy link
Owner Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 28, 2024
Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@uakihir0 uakihir0 self-assigned this Jun 28, 2024
@uakihir0
Copy link
Owner Author

@takke さん、こちらの PR をマージすると、クラス名とパッケージ名が結構変更になります。
来週頭にマージすることを考えています。よろしくお願いします。

@takke
Copy link
Contributor
takke commented Jun 29, 2024

@takke さん、こちらの PR をマージすると、クラス名とパッケージ名が結構変更になります。 来週頭にマージすることを考えています。よろしくお願いします。

了解しました。こちらはいつでも大丈夫です。よろしくお願いします。

@uakihir0
Copy link
Owner Author
uakihir0 commented Jul 1, 2024

マージします。

@uakihir0 uakihir0 merged commit 898af25 into main Jul 1, 2024
1 check passed
@takke
Copy link
Contributor
takke commented Jul 1, 2024

ZonePaneでも本構成変更に無事対応できました。実際に行った主な修正をメモしておきます。

work.socialhub.kbsky.Chat -> work.socialhub.kbsky.Bluesky (merged)
work.socialhub.kbsky.ChatFactory -> work.socialhub.kbsky.BlueskyFactory (merged)

work.socialhub.kbsky.api.entity.atproto -> work.socialhub.kbsky.api.entity.com.atproto
work.socialhub.kbsky.model.atproto -> work.socialhub.kbsky.model.com.atproto

work.socialhub.kbsky.api.entity.bsky -> work.socialhub.kbsky.api.entity.app.bsky
work.socialhub.kbsky.model.bsky -> work.socialhub.kbsky.model.app.bsky

work.socialhub.kbsky.model.app.bsky.feed.Threadgate* -> work.socialhub.kbsky.model.app.bsky.feed.FeedThreadgate*

work.socialhub.kbsky.api.entity.chat.convo.ChatConvo* -> work.socialhub.kbsky.api.entity.chat.bsky.convo.Convo*
work.socialhub.kbsky.model.chat.convo.ChatConvo* -> work.socialhub.kbsky.model.chat.bsky.convo.Convo*

work.socialhub.kbsky.model.chat.actor.ChatActor -> work.socialhub.kbsky.model.chat.bsky.actor.Actor
  • Note that the following classes have the same name. I handled this by setting the typealias.
work.socialhub.kbsky.model.app.bsky.actor.ActorDefsProfileViewBasic
work.socialhub.kbsky.model.chat.bsky.actor.ActorDefsProfileViewBasic

@uakihir0 uakihir0 deleted the f/dm branch July 6, 2024 11:55
@uakihir0 uakihir0 mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@uakihir0 uakihir0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uakihir0 @takke
0