Link tbbbind against static HWLOC instead of HWLOC 1.11 #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
isaevil
commented
Feb 14, 2025
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
| @@ -79,12 +79,17 @@ TEST_CASE("Test core types topology traversal correctness") { | |||
| TEST_CASE("Test validity of NUMA interfaces when HWLOC is not present on the system") { | |||
| std::vector<oneapi::tbb::numa_node_id> numa_indexes = oneapi::tbb::info::numa_nodes(); | |||
|
|
|||
| #if __TBB_PORTABLE_TBBBIND_AVAILABLE | |||
| REQUIRE_MESSAGE(numa_indexes[0] != -1, | |||
There was a problem hiding this comment.
I am not sure why -1 is used below. Is not that there automatic value for this or are these values unrelated?
There was a problem hiding this comment.
Constraints are set to task_arena::automatic by default. Don't know why in wasn't used in this test.
There was a problem hiding this comment.
There was a problem hiding this comment.
let's use task_arena::automatic then.
Co-authored-by: Aleksei Fedotov <aleksei.fedotov@intel.com>
| @@ -79,12 +79,17 @@ TEST_CASE("Test core types topology traversal correctness") { | |||
| TEST_CASE("Test validity of NUMA interfaces when HWLOC is not present on the system") { | |||
| std::vector<oneapi::tbb::numa_node_id> numa_indexes = oneapi::tbb::info::numa_nodes(); | |||
|
|
|||
| #if __TBB_PORTABLE_TBBBIND_AVAILABLE | |||
| REQUIRE_MESSAGE(numa_indexes[0] != -1, | |||
There was a problem hiding this comment.
let's use task_arena::automatic then.
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
aleksei-fedotov
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reserve "tbbbind" library name for the library, statically linked with HWLOC 2.x instead of HWLOC 1.11 as was proposed in https://github.com/uxlfoundation/oneTBB/blob/master/rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org#proposal
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information