8000 [dpc++][sycl] kernel bundle feature support by MikeDvorskiy · Pull Request #245 · uxlfoundation/oneDPL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[dpc++][sycl] kernel bundle feature support #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2021
Merged

[dpc++][sycl] kernel bundle feature support #245

merged 2 commits into from
May 19, 2021

Conversation

MikeDvorskiy
Copy link
Contributor

[dpc++][sycl] kernel bundle feature support

@MikeDvorskiy MikeDvorskiy requested a review from andreyfe1 May 17, 2021 13:52
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/sycl_kernel_bundle branch from 05a2549 to b6695e6 Compare May 17, 2021 14:48
andreyfe1
andreyfe1 reviewed May 18, 2021
View reviewed changes
Copy link
Contributor
@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me. Thanks for making changes

@MikeDvorskiy MikeDvorskiy merged commit f5dfdd3 into main May 19, 2021
@MikeDvorskiy MikeDvorskiy deleted the dev/mdvorski/sycl_kernel_bundle branch May 19, 2021 09:44
@DoyleLi
Copy link
Contributor
DoyleLi commented May 20, 2021
8000

Hi, it seems the file parallel_backend_sycl.h in this PR is not adapted to the latest compiler source code.
We have updated compiler for pre-CI checks at 19/05/2021. And it seems the PR will fail for pre-ci when use latest compiler.
Please refer to the latest CI checks in PR#251
#251

@MikeDvorskiy MikeDvorskiy restored the dev/mdvorski/sycl_kernel_bundle branch May 20, 2021 08:12
@MikeDvorskiy
Copy link
Contributor Author

It looks like a signature of sycl::get_kernel_bundle has been changed, see the update #254

ValentinaKats pushed a commit that referenced this pull request May 25, 2021
@MikeDvorskiy @ValentinaKats
[dpc++][sycl] kernel bundle feature support (#245)
77651c0 
[dpc++][sycl] + 'kernel bundle' feature support
haonanya pushed a commit to haonanya/oneDPL that referenced this pull request Aug 16, 2021
@fzou1
Merge pull request uxlfoundation#245 from haonanya/haonanya/remove-im…
65d5b66 
…age-support-110

Remove __IMAGE_SUPPORT__ macro for SPIR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyfe1 andreyfe1 andreyfe1 approved these changes

Assignees
No one assigned
4846
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeDvorskiy @DoyleLi @andreyfe1
0