8000 feat: changed describe query to support clickhouse by jerryc214 · Pull Request #750 · uwdata/mosaic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: changed describe query to support clickhouse #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerryc214
Copy link

Previously describe query used DESCRIBE, which was only supported by DuckDB. Changed query to DESC() which is supported by both DuckDB and Clickhouse.

@rpechuk rpechuk requested review from jheer and rpechuk April 22, 2025 19:41
Copy link
Member
@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to be updated.

It looks like click house supports describe, though: https://clickhouse.com/docs/sql-reference/statements/describe-table.

Copy link
Member
@jheer jheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, providing a mechanism that will work with both DuckDB and ClickHouse.

However, the test cases need to be updated to match the changes to the code. Please update packages/sql/test/query.test.js (e.g., around line 501) accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0