8000 Match File Upload Border to Design by kenzysoror · Pull Request #142 · uwblueprint/sistema · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Match File Upload Border to Design #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Match File Upload Border to Design #142

wants to merge 3 commits into from

Conversation

kenzysoror
Copy link
Contributor
@kenzysoror kenzysoror commented May 3, 2025 •
edited
Loading

Notion Ticket

NITS: Nice to Haves

Summary & Review Focus

  • Style UploadFile border to better match the design

Previous:
image

Current:
image

Note: I couldn't extract the exact dash, inter-dash gap, and corner gap sizes from the Figma (seems to just have a "dashed" border-style). I've eyeballed them for now, but they can be changed as needed here:

image

Testing Instructions

  1. Declare an absence to view the UploadFile component
  2. Ensure the UploadFile component matches the design

Checklist

  • PR title is descriptive and in imperative tense
  • Commit messages are descriptive, atomic, and follow best practices
  • Linter(s) have been run
  • Requested reviews from the PL and relevant team members

@vercel Vercel
Copy link
vercel bot commented May 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2025 10:39pm

@ChinemeremChigbo
Copy link
Member

Is it possible to have the border radius look like the Figma? I was able to do this:
image

But think we should try to match the curve without clipping the corners like the Figma:
image

If we aren't able to do that I think we can just leave things as they are.

ChinemeremChigbo
ChinemeremChigbo reviewed May 3, 2025
View reviewed changes
Copy link
Member
@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@kenzysoror
Copy link
Contributor Author

WORK LAPTOP SETUP IS DONE will get back on this🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenzysoror @ChinemeremChigbo
0