clippy: fix warnings from Rust 1.86 #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
=======================================
Coverage 87.30% 87.30%
=======================================
Files 31 31
Lines 6822 6824 +2
Branches 327 327
=======================================
+ Hits 5956 5958 +2
Misses 631 631
Partials 235 235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tavianator
reviewed
Apr 3, 2025
| @@ -401,7 +401,7 @@ fn format_directive<'entry>( | |||
| // even though it's arguably not 100% correct. | |||
| if *large_blocks { | |||
| // Ceiling divide in half. | |||
| (blocks + 1) / 2 | |||
| blocks.div_ceil(2) | |||
There was a problem hiding this comment.
Might as well make the same fix right above:
findutils/src/find/matchers/printf.rs
Line 396 in 5235d78
Side note: I think the code here is wrong, but that can be fixed in a different PR. It should be more like
let blocks = meta()?.blocks();
let len = blocks * STANDARD_BLOCK_SIZE;
let bs = if *large_blocks { 1024 } else { 512 };
blocks.div_ceil(len, bs)0247b27 to
5cb273e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings from the manual_div_ceil and double_ended_iterator_last lints.