8000 find: User/group ID fixes by tavianator · Pull Request #521 · uutils/findutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

find: User/group ID fixes #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

find: User/group ID fixes #521

merged 2 commits into from
Apr 4, 2025

Conversation

tavianator
Copy link
Contributor
@tavianator tavianator commented Apr 2, 2025 •
edited
Loading
  • find: Allow -user UID / -group GID
  • find: Implement -uid [-+]N, -gid [-+]N

@tavianator tavianator force-pushed the user-group-ids branch 2 times, most recently from 211b9d6 to 6684c52 Compare April 2, 2025 15:50
@codecov Codecov
Copy link
codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (81c39aa) to head (de42f9b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/find/mod.rs 91.66% 2 Missing and 2 partials ⚠️
src/find/matchers/group.rs 92.30% 1 Missing ⚠️
src/find/matchers/user.rs 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   87.30%   87.36%   +0.05%     
==========================================
  Files          31       31              
  Lines        6824     6812      -12     
  Branches      327      321       -6     
==========================================
- Hits         5958     5951       -7     
+ Misses        631      630       -1     
+ Partials      235      231       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tavianator @sylvestre
find: Allow -user UID / -group GID
6d264db 
POSIX says

> -user uname
>   The primary shall evaluate as true if the file belongs to the user
>   uname. If uname is a decimal integer and the getpwnam() (or
>   equivalent) function does not return a valid user name, uname shall
>   be interpreted as a user ID.

and similarly for -group.

Link: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/find.html
@tavianator @sylvestre
find: Implement -uid [-+]N, -gid [-+]N
de42f9b 
GNU find's -uid/-gid matchers take a comparable value.
@sylvestre sylvestre merged commit a04b499 into uutils:main Apr 4, 2025
20 checks passed
@tavianator tavianator deleted the user-group-ids branch April 4, 2025 14:01
@BrewTestBot BrewTestBot mentioned this pull request Apr 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tavianator @sylvestre
0