Wrap walkdir::DirEntry in a new type #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 65019fb has GNU testsuite comparison: |
|
Commit a7a5e4d has GNU testsuite comparison: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 66.08% 66.31% +0.22%
==========================================
Files 34 35 +1
Lines 4043 4278 +235
Branches 917 958 +41
==========================================
+ Hits 2672 2837 +165
- Misses 1000 1041 +41
- Partials 371 400 +29 ☔ View full report in Codecov by Sentry. |
|
Commit 72bb813 has GNU testsuite comparison: |
|
Impressive: |
|
Commit 276ebda has GNU testsuite comparison: |
|
Commit 28f1a43 has GNU testsuite comparison: |
|
Commit d5a3423 has GNU testsuite comparison: |
Closed
|
Commit aba5c66 has GNU testsuite comparison: |
hanbings
reviewed
Aug 12, 2024
|
Commit b194948 has GNU testsuite comparison: |
find_time() relies on the working directory, but e.g. delete_on_dot_dir() will temporarily change directories, causing find_time() to fail when run in parallel.
The global exit code can polute the results of other tests. Link: uutils/coreutils#5777
The new type wraps DirEntry when possible, but also lets us pass a valid entry to matchers when walkdir returns a broken symlink error. It also implements a Metadata cache (part of uutils#430).
|
Commit 7b97d74 has GNU testsuite comparison: |
hanbings
approved these changes
Aug 13, 2024
|
Will there be more updates here? Should we merge it? |
|
This should be good to go! Thanks |
tavianator
added a commit
to tavianator/findutils
that referenced
this pull request
Mar 28, 2025
The uucore function has the downside of leaking the failure state between unrelated tests, because the exit code is global. PR uutils#436 introduced a method on MatcherIO which solves the problem, but future PRs added new uses of uucore::error::set_exit_code().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #420.
Closes #12. Closes #308. Closes #379. Closes #412. Closes #440. Implements the
Metadatacaching part of #430.