all: change remaining usage codes of 2 to 1 for GNU compat #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d09949f to
3dd6b08
Compare
|
do you think we could have a test to verify that we don't regress? :) |
3dd6b08 to
680765b
Compare
|
I was worried you were gonna ask that :) I've added a simple test for all the utils. |
|
ah ah, yeah, I am quite predictable :) isn't it @calixteman ? :) |
Oh yeah 😄 |
680765b to
5a6e9e2
Compare
|
I've now included some more utils that were off (like the ones that should return 125) and I included tests for them. |
5a6e9e2 to
9177cb7
Compare
|
Nice side effect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3102
Changes the exit code for the utils below from 2 to 1. A few utils remain with more complicated errors.