df: fix incorrect rounding of size header #3530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
approved these changes
May 18, 2022
| @@ -245,6 +245,7 @@ mod tests { | |||
| assert_eq!(to_magnitude_and_suffix(1001).unwrap(), "1.1kB"); | |||
| assert_eq!(to_magnitude_and_suffix(1023).unwrap(), "1.1kB"); | |||
| assert_eq!(to_magnitude_and_suffix(1025).unwrap(), "1.1kB"); | |||
| assert_eq!(to_magnitude_and_suffix(10_001).unwrap(), "11kB"); | |||
There was a problem hiding this comment.
So in this case, the quotient of 10_001 and 1_000 is 10.001, which gets rounded up to 11 due to the new condition added to the code. Interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some incorrect rounding of the size header. For example,
10_001was rounded up to10.1kBinstead of11kB.