df: show error if all types are excluded #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1b874b to
22a46b4
Compare
tertsdiepraam
approved these changes
Apr 19, 2022
| .arg("--output=fstype") | ||
| .succeeds() | ||
| .stdout_move_str(); | ||
| let fs_types: HashSet<_> = fs_types.lines().skip(1).collect(); |
There was a problem hiding this comment.
Nice test! Is there a particular reason to use a HashSet here instead of a Vec? If not then HashSet is still fine, but I'm just curious :)
There was a problem hiding this comment.
No, it was more of an intuitive decision to use a HashSet. It avoids duplicates because for the test it only matters that a file system type is there, but not how often.
tertsdiepraam
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreutils df -x ext4 -x tmpfs -x devtmpfs -x vfatwill now show an error (this is on my machine, on other machines you might have to specify other types to get the error).Fixes #3409.