8000 du: add support for --exclude and --exclude-from by sylvestre · Pull Request #3381 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

du: add support for --exclude and --exclude-from #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 11, 2022
Merged

du: add support for --exclude and --exclude-from #3381

merged 8 commits into from
Apr 11, 2022

Conversation

sylvestre
Copy link
Contributor
@sylvestre sylvestre commented Apr 9, 2022 •
edited
Loading

And add an option --verbose (doesn't exist in GNU)
Fixes gnu test tests/du/exclude.sh & tests/du/slash.sh

Leverages glob

@sylvestre
du: add support for --exclude and --exclude-from
b0b9658 
And add an option --verbose (doesn't exist in GNU)
@sylvestre
Copy link
Contributor Author

Unexpected good news. I was only focusing on exclude.sh :)

Warning: Congrats! The gnu test tests/du/exclude is no longer failing!
Warning: Congrats! The gnu test tests/du/slash is no longer failing!

@sylvestre sylvestre requested a review from tertsdiepraam April 9, 2022 20:30
@sylvestre sylvestre requested a review from jfinkels April 9, 2022 23:45
tertsdiepraam
tertsdiepraam reviewed Apr 10, 2022
View reviewed changes
@tertsdiepraam
Copy link
Member

Cool! I used globset before on ls and it was later removed due to binary size (#2781). Do you think it's worth the binary size in this case?

@sylvestre
Copy link
Contributor Author

Oh, I forgot about globset size. I will have a look

@sylvestre sylvestre requested a review from tertsdiepraam April 11, 2022 12:42
tertsdiepraam
tertsdiepraam reviewed Apr 11, 2022
View reviewed changes
Copy link
Member
@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have a few suggestions, but this makes a lot of sense!

sylvestre and others added 3 commits April 11, 2022 20:01
@sylvestre sylvestre merged commit 8b719a8 into uutils:main Apr 11, 2022
@sylvestre sylvestre deleted the du-exclude branch April 11, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

@jfinkels jfinkels Awaiting requested review from jfinkels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @tertsdiepraam
0