dd: correct order and phrasing of truncated record #3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place the "truncated records" line below the "records out" line in the
status report produced by `dd` and properly handle the singularization
of the word "record" in the case of 1 truncated record. This matches
the behavior of GNU `dd`.
For example
$ printf "ab" | dd cbs=1 conv=block status=noxfer > /dev/null
0+1 records in
0+1 records out
1 truncated record
$ printf "ab\ncd\n" | dd cbs=1 conv=block status=noxfer > /dev/null
0+1 records in
0+1 records out
2 truncated records
54e60e0 to
766c85f
Compare
Comment on lines
+786
to
+790
| match update.read_stat.records_truncated { | ||
| 0 => {} | ||
| 1 => eprintln!("1 truncated record"), | ||
| n => eprintln!("{} truncated records", n), | ||
| } |
There was a problem hiding this comment.
This is just amazing. It's clever but also extremely readable. I love it :)
There was a problem hiding this comment.
Rust! I'm really enjoying using it 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the "truncated records" line below the "records out" line in the
status report produced by
ddand properly handle the singularizationof the word "record" in the case of 1 truncated record. This matches
the behavior of GNU
dd.For example