8000 seq: correct fixed-width spacing for inf sequences by jfinkels · Pull Request #2740 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

seq: correct fixed-width spacing for inf sequences #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

seq: correct fixed-width spacing for inf sequences #2740

merged 1 commit into from
Nov 12, 2021

Conversation

jfinkels
Copy link
Collaborator
@jfinkels jfinkels commented Nov 9, 2021

Pad infinity and negative infinity values with spaces when using the
-w option to seq. This corrects the behavior of seq to match that
of the GNU version:

$ seq -w 1.000 inf inf | head -n 4
1.000
  inf
  inf
  inf

Previously, it incorrectly padded with 0s instead of spaces.

@jfinkels
seq: correct fixed-width spacing for inf sequences
0b86afa 
Pad infinity and negative infinity values with spaces when using the
`-w` option to `seq`. This corrects the behavior of `seq` to match that
of the GNU version:

    $ seq -w 1.000 inf inf | head -n 4
    1.000
      inf
      inf
      inf

Previously, it incorrectly padded with 0s instead of spaces.
@sylvestre
Copy link
Contributor

Interesting, GNU isn't changing

Changes from master: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0

@sylvestre sylvestre merged commit 177374a into uutils:master Nov 12, 2021
@jfinkels jfinkels deleted the seq-inf-width-spaces branch November 16, 2021 02:31
@jfinkels
Copy link
Collaborator Author

The GNU test coverage will not change. There are many test cases in the tests/misc/seq.pl file, many of which will continue to fail regardless of this change: https://github.com/coreutils/coreutils/blob/master/tests/misc/seq.pl My understanding is that the PASS and FAIL numbers reported by util/run-gnu-test.sh are only report PASS if the entire file passes. Perhaps I'm mistaken about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfinkels @sylvestre
0