more: Implement option '-d' #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miDeb
reviewed
Jun 9, 2021
src/uu/more/src/more.rs
Outdated
| let status = format!("--More--({})", status_inner); | ||
|
|
||
| let banner = match (silent, wrong_key) { | ||
| (true, true) => "[Press 'h' for instructions.]".to_string(), |
There was a problem hiding this comment.
We suggest pressing 'h', but that's not yet implemented. I think we shouldn't give this suggestion as long as 'h' is not yet implemented.
There was a problem hiding this comment.
Maybe "[Press 'h' for instructions. (unimplemented)]" so that it's clear that it should be there but still needs to be added?
There was a problem hiding this comment.
Change suggestion to "unimplemented" from @tertsdiepraam suggestion.
Implement option '-d' (silent mode) Related to uutils#2320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement option '-d' (silent mode)
The method used in
make_prompt_and_flush()is a bit messy to deal with both silent and help text.If you have any suggestions, please comment. I would be more than happy to fix it.
Related to #2320