8000 Bump MSRV to 1.82.0 by drinkcat · Pull Request #7394 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump MSRV to 1.82.0 #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

Bump MSRV to 1.82.0 #7394

merged 2 commits into from
Mar 4, 2025

Conversation

drinkcat
Copy link
Contributor
@drinkcat drinkcat commented Mar 4, 2025

Fixes #7393.

@sylvestre
Copy link
Contributor

@cakebaker ok with you ? :)

@sylvestre
Copy link
Contributor
sylvestre commented Mar 4, 2025 •
edited
Loading

Needs to fix:

      --> tests/common/util.rs:411:9
      |
  411 |         self.exit_status.map_or(true, |e| e.success())
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_none_or instead: `self.exit_status.is_none_or(|e| e.success())`

@cakebaker
Copy link
Contributor

@sylvestre yes :)

@drinkcat
tests/common/util: Use is_none_or instead of map_or
c6e06af 
Following clippy advice:
error: this `map_or` can be simplified
     --> tests\common\util.rs:411:9
      |
  411 |         self.exit_status.map_or(true, |e| e.success())
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_none_or instead: `self.exit_status.is_none_or(|e| e.success())`
@drinkcat
Copy link
Contributor Author
drinkcat commented Mar 4, 2025

Needs to fix:

      --> tests/common/util.rs:411:9
      |
  411 |         self.exit_status.map_or(true, |e| e.success())
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_none_or instead: `self.exit_status.is_none_or(|e| e.success())`

done

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 72299d3 into uutils:main Mar 4, 2025
65 checks passed
@drinkcat drinkcat mentioned this pull request Mar 4, 2025
Closed
@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selinux build is broken with MRSV (1.79.0)
3 participants
@drinkcat @sylvestre @cakebaker
0