8000 rm: correct prompt for removing inaccessible dir by jfinkels · Pull Request #7325 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rm: correct prompt for removing inaccessible dir #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jfinkels
Copy link
Collaborator

Change the prompt when attempting to remove an inaccessible directory. Before this commit, the prompt was

rm: remove write-protected directory 'dir'?

After this commit, the prompt is

rm: attempt removal of inaccessible directory 'dir'?

This required slightly adjusting the logic for which prompt messages to display under which circumstances.

Fixes #7309.

Change the prompt when attempting to remove an inaccessible
directory. Before this commit, the prompt was

    rm: remove write-protected directory 'dir'?

After this commit, the prompt is

    rm: attempt removal of inaccessible directory 'dir'?

This required slightly adjusting the logic for which prompt messages to
display under which circumstances.

Fixes uutils#7309.
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@jfinkels jfinkels marked this pull request as ready for review February 19, 2025 02:02
@cakebaker cakebaker merged commit 99d4fbd into uutils:main Feb 19, 2025
65 checks passed
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rm: -d shows wrong prompt message for inaccessible dir
2 participants
0