head: fix bug reading back through files #7248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c492ef to
8dfc2b6
Compare
8dfc2b6 to
74ef039
Compare
|
how can we reproduce the issue at the level of the command? thanks :) |
|
If you run you should see the issue. With GNU head you'll get the correct output... With the Rust implementation you'll see |
|
maybe add such test here https://github.com/uutils/coreutils/blob/main/tests/by-util/test_head.rs ? :) |
|
Sounds reasonable :) |
0b8afef to
9f0c360
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Feb 3, 2025
| @@ -392,6 +392,29 @@ fn test_presume_input_pipe_5_chars() { | |||
| .stdout_is_fixture("lorem_ipsum_5_chars.expected"); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_read_backwards_lines_large_file() { | |||
There was a problem hiding this comment.
sorry, I would prefer to create these files on the fly, no need to add big files in the tree :)
and I guess you can reproduce it with only 1 => 50 ?
There was a problem hiding this comment.
Updated the test code to generate the files on the fly. Files need to be pretty big since the bug is only seen for backward searches >128K (i.e. double the BUF_SIZE value in head.rs)
9f0c360 to
73c7469
Compare
|
GNU testsuite comparison: |
73c7469 to
9d5d4b6
Compare
|
GNU testsuite comparison: |
Fix issue uutils#7247. Rework logic for reading/seeking backwards through files. Bug was seen when reading back through large files. Added test case to validate fix.
9d5d4b6 to
3ceb338
Compare
|
GNU t 8000 estsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #7247.
Rework logic for reading/seeking backwards through files. Bug was seen when reading back through large files. Added test case to validate fix.